music-kraken/music-kraken-core
3
2
Fork 0
Code Issues 10 Pull Requests 1 Packages Projects 2 Releases Wiki Activity

Correct duplicate values #22

Merged
Hazel merged 3 commits from issue16 into experimental 2024-05-08 12:33:35 +00:00
Conversation 5 Commits 3 Files Changed 4 +18 -8
Luna commented 2024-05-07 11:56:26 +00:00
Owner
Copy Link

Fix For Issue 16: Duplicate Metadata

Fix For Issue 16: Duplicate Metadata
Luna added 1 commit 2024-05-07 11:56:26 +00:00
Correct duplicate values
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
709c5ebaa8
Hazel commented 2024-05-07 11:58:41 +00:00
Owner
Copy Link

Looks good but does it work with lyrics?

Looks good but does it work with lyrics?
Luna commented 2024-05-07 12:00:19 +00:00
Author
Owner
Copy Link

Depends on what data type lyrics are, normal string?

Depends on what data type lyrics are, normal string?
Hazel commented 2024-05-07 12:02:40 +00:00
Owner
Copy Link

Look in lyrics.py

Look in `lyrics.py`
Luna commented 2024-05-07 12:15:23 +00:00
Author
Owner
Copy Link

Looks good as long as the data is identically i don't see a reason why it shouldn't work.

Looks good as long as the data is identically i don't see a reason why it shouldn't work.
Hazel commented 2024-05-07 12:19:38 +00:00
Owner
Copy Link

have you tried it?

have you tried it?
Luna added 1 commit 2024-05-08 10:29:03 +00:00
fix for lyrics
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
e3e7aea959
Luna added 1 commit 2024-05-08 10:34:25 +00:00
Merge branch 'experimental' into issue16
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
4e0b005170
Hazel merged commit 949583225a into experimental 2024-05-08 12:33:35 +00:00
Hazel deleted branch issue16 2024-05-08 12:33:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: music-kraken/music-kraken-core#22
No description provided.
Delete Branch "issue16"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?