yes

src/music_kraken/database/objects/metadata.py

@@ -39,7 +39,7 @@ class Mapping(Enum):
     LYRICIST = "TEXT"
     WRITER = "TEXT"
     ARTIST = "TPE1"
-    LANGUAGE = "TLAN" # https://en.wikipedia.org/wiki/ISO_639-2
+    LANGUAGE = "TLAN"  # https://en.wikipedia.org/wiki/ISO_639-2
     ITUNESCOMPILATION = "TCMP"
     REMIXED_BY = "TPE4"
     RADIO_STATION_OWNER = "TRSO"
@@ -257,23 +257,20 @@ class MetadataAttribute:
         # the mutagen object for each frame will be generated dynamically
         id3_dict: Dict[any, list]
 
-
         def __init__(self, id3_dict: Dict[any, list] = None) -> None:
             self.id3_dict = dict()
             if id3_dict is not None:
                 self.add_metadata_dict(id3_dict)
 
         def __setitem__(self, frame, value_list: list, override_existing: bool = True):
-            if len(value_list) == 0:
-                return
             if type(value_list) != list:
                 raise ValueError(f"can only set attribute to list, not {type(value_list)}")
-            
-            new_val = [i for i in value_list if i is not None]
-                        
+
+            new_val = [i for i in value_list if i not in {None, ''}]
+
             if len(new_val) == 0:
                 return
- 
+
             if override_existing:
                 self.id3_dict[frame] = new_val
             else:
@@ -288,10 +285,9 @@ class MetadataAttribute:
                 return None
             return self.id3_dict[key]
 
-
         def delete_field(self, key: str):
-            if key in self.id3_attributes:
-                return self.id3_attributes.pop(key)
+            if key in self.id3_dict:
+                return self.id3_dict.pop(key)
 
         def add_metadata_dict(self, metadata_dict: dict, override_existing: bool = True):
             for field_enum, value in metadata_dict.items():
@@ -305,16 +301,15 @@ class MetadataAttribute:
             """
 
             self.add_metadata_dict(other.id3_dict, override_existing=override_existing)
-        
+
         def merge_many(self, many_other):
             """
             adds the values of many other metadata objects to this one
             """
-            
+
             for other in many_other:
                 self.merge(other)
 
-
         def get_id3_value(self, field):
             if field not in self.id3_dict:
                 return None
@@ -327,6 +322,9 @@ class MetadataAttribute:
                 if type(element) == str:
                     continue
 
+                if type(element) in {int}:
+                    list_data[i] = str(element)
+
                 if type(element) == ID3Timestamp:
                     list_data[i] = element.timestamp
                     continue
@@ -350,7 +348,6 @@ class MetadataAttribute:
                 rows.append(f"{key} - {str(value)}")
             return "\n".join(rows)
 
-
         def __iter__(self):
             """
             returns a generator, you can iterate through,

src/music_kraken/database/objects/song.py

@@ -200,7 +200,7 @@ class Song(DatabaseObject, SourceAttribute, MetadataAttribute):
         metadata = MetadataAttribute.Metadata({
             id3Mapping.TITLE: [self.title],
             id3Mapping.ISRC: [self.isrc],
-            id3Mapping.LENGTH: [str(self.length)],
+            id3Mapping.LENGTH: [self.length],
             id3Mapping.GENRE: [self.genre],
             id3Mapping.TRACKNUMBER: [self.tracksort_str]
         })
@@ -321,6 +321,8 @@ class Album(DatabaseObject, SourceAttribute, MetadataAttribute):
         })
 
     def get_copyright(self) -> str:
+        if self.date is None:
+            return None
         if self.date.year == 1 or self.label is None:
             return None