music-kraken/music-kraken-core
3
2
Fork 0
Code Issues 10 Pull Requests 1 Packages Projects 2 Releases Wiki Activity

cleaned up search

Browse Source
This commit is contained in:
Hellow2 2023-05-23 16:30:35 +02:00
parent 67b4a3bc65
commit 4cc36087b6
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/music_kraken/pages/encyclopaedia_metallum.py
View File

@ -50,15 +50,24 @@ class EncyclopaediaMetallum(Page):
logger=ENCYCLOPAEDIA_METALLUM_LOGGER logger=ENCYCLOPAEDIA_METALLUM_LOGGER
) )
@classmethod super().__init__()
def search_for_song(cls, query: Query) -> List[Song]:
def song_search(self, song: Song) -> List[Song]:
endpoint = "https://www.metal-archives.com/search/ajax-advanced/searching/songs/?songTitle={song}&bandName={" \ endpoint = "https://www.metal-archives.com/search/ajax-advanced/searching/songs/?songTitle={song}&bandName={" \
"artist}&releaseTitle={album}&lyrics=&genre=&sEcho=1&iColumns=5&sColumns=&iDisplayStart=0" \ "artist}&releaseTitle={album}&lyrics=&genre=&sEcho=1&iColumns=5&sColumns=&iDisplayStart=0" \
"&iDisplayLength=200&mDataProp_0=0&mDataProp_1=1&mDataProp_2=2&mDataProp_3=3&mDataProp_4=4&_" \ "&iDisplayLength=200&mDataProp_0=0&mDataProp_1=1&mDataProp_2=2&mDataProp_3=3&mDataProp_4=4&_" \
"=1674550595663" "=1674550595663"
r = cls.CONNECTION.get( """
endpoint.format(song=query.song_str, artist=query.artist_str, album=query.album_str) The difficult question I am facing is, that if I try every artist, with every song, with every album,
I end up with a quadratic runtime complecety O(n^2), where every step means one web request.
This.
Is not good.
"""
r = self.connection.get(
endpoint.format(song=song.title, artist=query.artist_str, album=query.album_str)
) )
if r is None: if r is None:
return [] return []