Elara Elara6331
Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support

This is not correct. If no content has been written, you should still create the file because the user might want to create a custom file using a command like touch.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support

Use os.MkdirAll here instead so that it creates parent directories, and handle the error (just return it).

Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support

err is returned twice here

Elara6331 suggested changes for Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support
Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:14:07 +00:00
Added FUSE support

Sorry it's taken me a while to respond. I wanted to test this PR but my PineTime wasn't booting. Now that I've gotten it to boot, I'll test this and get back to you.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 23:34:33 +00:00
Added FUSE support

The err can be several different kinds of errors, and FSError is just one of them. It's actually a type I made. You can see it here: https://gitea.arsenm.dev/Arsen6331/infinitime/src/commit/512

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support
Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support
Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

These should be debug logs rather than info logs. Also, the message should be a bit more specific, something like "FUSE getattr". Same for all the similar logs.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

Minor typo, it's "success"

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

You should definitely handle this error

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

This error needs to be handled, you can just return it in this case and update the code that calls this function to do the actual handling

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

These variables should go above BuildRootNode because it's using them and it would be more readable that way. Also, Go doesn't require semicolons, you can remove those.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

FUSE should be started before the socket (socket should always be last)

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

This function should be called startFUSE instead to adhere to Go naming conventions

Elara6331 suggested changes for Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

Thanks for your PR. There are some changes I'd like, mostly readability improvements.

Elara6331 commented on issue Elara6331/itd#54 2023-02-27 23:17:23 +00:00
FUSE suppport

I've had a closer look at your fork. It looks good. The only thing I'd say should be changed is that the fuse.go file should only contain the startFuse function (which should be called…

Elara6331 pushed to master at lure/lure 2023-02-27 21:30:23 +00:00
70e05f5242 Fall back to English if system locale is 'C'
Elara6331 commented on issue Elara6331/itd#54 2023-02-26 17:20:17 +00:00
FUSE suppport

Assuming the fuse library you're using doesn't link libfuse, I think this is a great idea. I don't think it does, but it doesn't explicitly state that anywhere. The easiest way to check is to…

Elara6331 pushed to master at lure/lure 2023-02-26 00:48:00 +00:00
6341dc4c55 Properly list all installed packages, and ignore blacklisted ones