Elara6331/pcre
1
0
Fork 1
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

recompute ovecSlice #2

Open
jettero wants to merge 1 commits from jettero/pcre:recompute-ovecSlice into master
pull from: jettero/pcre:recompute-ovecSlice
merge into: Elara6331:master
Conversation 0 Commits 1 Files Changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pcre.go
View File

@ -592,7 +592,7 @@ func (r *Regexp) SetCallout(fn func(cb *CalloutBlock) int32) error {
calloutStrBytes := unsafe.Slice((*byte)(unsafe.Pointer(ccb.Fcallout_string)), ccb.Fcallout_string_length) calloutStrBytes := unsafe.Slice((*byte)(unsafe.Pointer(ccb.Fcallout_string)), ccb.Fcallout_string_length)
cb.CalloutString = string(calloutStrBytes) cb.CalloutString = string(calloutStrBytes)
ovecSlice := unsafe.Slice((*lib.Tsize_t)(unsafe.Pointer(ccb.Foffset_vector)), (ccb.Fcapture_top*2)-1) ovecSlice := unsafe.Slice((*lib.Tsize_t)(unsafe.Pointer(ccb.Foffset_vector)), 2+(ccb.Fcapture_top-1)*2)
Elara6331 commented 2023-07-26 22:23:35 +00:00
Review
Copy Link

The 2+ isn't needed because that's what the ovecSlice = ovecSlice[2:] line is for. Otherwise, this looks good, thanks.

The `2+` isn't needed because that's what the `ovecSlice = ovecSlice[2:]` line is for. Otherwise, this looks good, thanks.
if len(ovecSlice) > 2 { if len(ovecSlice) > 2 {
ovecSlice = ovecSlice[2:] ovecSlice = ovecSlice[2:]
for i := 0; i < len(ovecSlice); i += 2 { for i := 0; i < len(ovecSlice); i += 2 {