recompute ovecSlice #2

jettero · 2023-07-23T18:02:48Z

jettero commented

2023-07-23 18:02:48 +00:00

First-time contributor

The first two entries are always PCRE2_UNSET, then there's 2*(capture_top-1). At least that's how I read https://www.pcre.org/current/doc/html/pcre2callout.html

jettero added 1 commit 2023-07-23 18:02:48 +00:00

recompute ovecSlice 54d8a33099

The first two entries are always PCRE2_UNSET, then there's 2*(capture_top-1). At least that's how I read https://www.pcre.org/current/doc/html/pcre2callout.html

Elara6331 requested changes 2023-07-26 22:23:47 +00:00

pcre.go

						
				@ -594,2 +594,2 @@

						ovecSlice := unsafe.Slice((*lib.Tsize_t)(unsafe.Pointer(ccb.Foffset_vector)), (ccb.Fcapture_top*2)-1)

						ovecSlice := unsafe.Slice((*lib.Tsize_t)(unsafe.Pointer(ccb.Foffset_vector)), 2+(ccb.Fcapture_top-1)*2)

Elara6331 commented

2023-07-26 22:23:35 +00:00

The 2+ isn't needed because that's what the ovecSlice = ovecSlice[2:] line is for. Otherwise, this looks good, thanks.

The `2+` isn't needed because that's what the `ovecSlice = ovecSlice[2:]` line is for. Otherwise, this looks good, thanks.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u recompute-ovecSlice:jettero-recompute-ovecSlice

git checkout jettero-recompute-ovecSlice

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Elara6331/pcre#2