Elara6331/itd
4
6
Fork 12
Code Issues 8 Pull Requests 1 Projects Releases 11 Wiki Activity

Fix crash in filesystem API. #69

Merged
Elara6331 merged 1 commits from vchigrin/itd:fix-crash into master 2024-07-04 03:25:39 +00:00
Conversation 0 Commits 1 Files Changed 1 +4 -1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/fs.go
View File

@ -42,7 +42,10 @@ func (c *FSClient) Mkdir(ctx context.Context, paths ...string) error {
func (c *FSClient) ReadDir(ctx context.Context, dir string) ([]FileInfo, error) {
res, err := c.client.ReadDir(ctx, &rpc.PathRequest{Path: dir})
return convertEntries(res.Entries), err
if err != nil {
return nil, err
}
return convertEntries(res.Entries), nil
Elara6331 marked this conversation as resolved Outdated
Elara6331 commented 2024-07-03 03:57:37 +00:00
Outdated
Review
Copy Link

Thanks for the PR! Can you please also change return convertEntries(res.Entries), err to return convertEntries(res.Entries), nil?

Thanks for the PR! Can you please also change `return convertEntries(res.Entries), err` to `return convertEntries(res.Entries), nil`?
}
func convertEntries(e []*rpc.FileInfo) []FileInfo {