added setting of timezone #16

cybuzuma · 2022-05-29T21:49:39Z

cybuzuma commented

2022-05-29 21:49:39 +00:00

First-time contributor

Corresponding to https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4.

For rationale, see there.

I am afraid I am not a go developer and as such am not 100% sure how to set go.mod correctly to pull in the yet to be released version of the infinitime lib.

Corresponding to https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4. For rationale, see there. I am afraid I am not a go developer and as such am not 100% sure how to set go.mod correctly to pull in the yet to be released version of the infinitime lib.

cybuzuma added 1 commit 2022-05-29 21:49:40 +00:00

added setting of timezone b7d8d4376d

Elara6331 commented

2022-05-30 05:36:52 +00:00

This looks good. Please look at the comment I left on Arsen6331/infinitime#4. I will merge once the InfiniTime PR gets merged. As a sidenote, you can make the go.mod use the unreleased version by replacing the version within the file with the commit hash and then running go mod tidy. This will not be possible until the PR is merged though, because the import path of your fork would be different.

This looks good. Please look at the comment I left on Arsen6331/infinitime#4. I will merge once the InfiniTime PR gets merged. As a sidenote, you can make the `go.mod` use the unreleased version by replacing the version within the file with the commit hash and then running `go mod tidy`. This will not be possible until the PR is merged though, because the import path of your fork would be different.

Elara6331 added the

Waiting

Enhancement

labels 2022-05-30 05:37:06 +00:00

Elara6331 added a new dependency 2022-05-30 05:37:51 +00:00

Elara6331/infinitime#4 - added local time characteristic

cybuzuma added 1 commit 2022-05-30 20:30:23 +00:00

removed removed call to SetTimezone e36f0b4f66

cybuzuma commented

2022-05-30 20:38:40 +00:00

First-time contributor

adapted to changes in https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4

cybuzuma commented

2022-05-30 20:40:23 +00:00

First-time contributor

lol, gitea has a point here. No changes to this code anymore, after adapting https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4

I do not have the rights to close this PR though, as it depends on https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4 which I can not change.

lol, gitea has a point here. No changes to this code anymore, after adapting https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4 I do not have the rights to close this PR though, as it depends on https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4 which I can not change.

Elara6331 commented

2022-05-30 22:14:26 +00:00

Ok, I'll close it now. Thank you.

Elara6331 removed a dependency 2022-05-30 22:14:36 +00:00

Elara6331/infinitime#4 - added local time characteristic

Elara6331 closed this pull request

2022-05-31 06:20:15 +00:00