Elara6331/itd
4
6
Fork 12
Code Issues 8 Pull Requests 1 Projects Releases 11 Wiki Activity

added setting of timezone #16

Closed
cybuzuma wants to merge 0 commits from cybuzuma/itd:gatt_localtime into master
pull from: cybuzuma/itd:gatt_localtime
merge into: Elara6331:master
Conversation 4 Commits - Files Changed 83
cybuzuma commented 2022-05-29 21:49:39 +00:00
First-time contributor
Copy Link

Corresponding to https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4.

For rationale, see there.

I am afraid I am not a go developer and as such am not 100% sure how to set go.mod correctly to pull in the yet to be released version of the infinitime lib.

Corresponding to https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4. For rationale, see there. I am afraid I am not a go developer and as such am not 100% sure how to set go.mod correctly to pull in the yet to be released version of the infinitime lib.
cybuzuma added 1 commit 2022-05-29 21:49:40 +00:00
added setting of timezone b7d8d4376d
Elara6331 commented 2022-05-30 05:36:52 +00:00
Owner
Copy Link

This looks good. Please look at the comment I left on Arsen6331/infinitime#4. I will merge once the InfiniTime PR gets merged. As a sidenote, you can make the go.mod use the unreleased version by replacing the version within the file with the commit hash and then running go mod tidy. This will not be possible until the PR is merged though, because the import path of your fork would be different.

This looks good. Please look at the comment I left on Arsen6331/infinitime#4. I will merge once the InfiniTime PR gets merged. As a sidenote, you can make the `go.mod` use the unreleased version by replacing the version within the file with the commit hash and then running `go mod tidy`. This will not be possible until the PR is merged though, because the import path of your fork would be different.
Elara6331 added the
Waiting
Enhancement
 labels 2022-05-30 05:37:06 +00:00
Elara6331 added a new dependency 2022-05-30 05:37:51 +00:00
Elara6331/infinitime#4 - added local time characteristic
cybuzuma added 1 commit 2022-05-30 20:30:23 +00:00
removed removed call to SetTimezone e36f0b4f66
cybuzuma commented 2022-05-30 20:38:40 +00:00
Author
First-time contributor
Copy Link

adapted to changes in https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4

adapted to changes in https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4
cybuzuma commented 2022-05-30 20:40:23 +00:00
Author
First-time contributor
Copy Link

lol, gitea has a point here. No changes to this code anymore, after adapting https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4

I do not have the rights to close this PR though, as it depends on https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4 which I can not change.

lol, gitea has a point here. No changes to this code anymore, after adapting https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4 I do not have the rights to close this PR though, as it depends on https://gitea.arsenm.dev/Arsen6331/infinitime/pulls/4 which I can not change.
Elara6331 commented 2022-05-30 22:14:26 +00:00
Owner
Copy Link

Ok, I'll close it now. Thank you.

Ok, I'll close it now. Thank you.
Elara6331 removed a dependency 2022-05-30 22:14:36 +00:00
Elara6331/infinitime#4 - added local time characteristic
Elara6331 closed this pull request 2022-05-31 06:20:15 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Something is not working
Cantfix
This issue cannot be fixed in ITD
Duplicate
This issue or pull request already exists
Enhancement
New feature
External
This issue is not in ITD
Help Wanted
Need some help
In Progress
This issue is currently being worked on
Invalid
Something is wrong
Question
More information is needed
Waiting
Waiting for something external to be completed to allow completion of issue
Waiting For Info
Waiting for additional information about issue
Waiting for Upstream
Waiting for an upstream project to fix an issue
Wontfix
This won't be fixed
No Label
Enhancement
Waiting
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Elara6331
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Elara6331/itd#16
No description provided.
Delete Branch "cybuzuma/itd:gatt_localtime"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?