Elara6331/itd
4
6
Fork 12
Code Issues 8 Pull Requests 1 Projects Releases 11 Wiki Activity

Fix crash in filesystem API. #69

Merged
Elara6331 merged 1 commits from vchigrin/itd:fix-crash into master 2024-07-04 03:25:39 +00:00
Conversation 0 Commits 1 Files Changed 1 +4 -1
vchigrin commented 2024-07-02 20:38:03 +00:00
Contributor
Copy Link

This help me fix #issues/64

This help me fix #issues/64
vchigrin added 1 commit 2024-07-02 20:38:04 +00:00
Elara6331 requested changes 2024-07-03 03:57:41 +00:00
Dismissed
api/fs.go Outdated
@ -45,1 +45,4 @@
if err != nil {
return nil, err
}
return convertEntries(res.Entries), err
Elara6331 commented 2024-07-03 03:57:37 +00:00
Owner
Copy Link

Thanks for the PR! Can you please also change return convertEntries(res.Entries), err to return convertEntries(res.Entries), nil?

Thanks for the PR! Can you please also change `return convertEntries(res.Entries), err` to `return convertEntries(res.Entries), nil`?
Elara6331 marked this conversation as resolved
vchigrin force-pushed fix-crash from d1e5157008 to d7606c4327 2024-07-03 21:24:18 +00:00 Compare
Elara6331 approved these changes 2024-07-04 03:24:47 +00:00
Elara6331 left a comment
Owner
Copy Link

Большое спасибо!

Большое спасибо!
❤️ 1
Elara6331 merged commit 243826bd67 into master 2024-07-04 03:25:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Elara6331
Labels
Clear labels   
Bug

Something is not working

  
Cantfix

This issue cannot be fixed in ITD

  
Duplicate

This issue or pull request already exists

  
Enhancement

New feature

  
External

This issue is not in ITD

  
Help Wanted

Need some help

  
In Progress

This issue is currently being worked on

  
Invalid

Something is wrong

  
Question

More information is needed

  
Waiting

Waiting for something external to be completed to allow completion of issue

  
Waiting For Info

Waiting for additional information about issue

  
Waiting for Upstream

Waiting for an upstream project to fix an issue

  
Wontfix

This won't be fixed

No Label
Bug
Cantfix
Duplicate
Enhancement
External
Help Wanted
In Progress
Invalid
Question
Waiting
Waiting For Info
Waiting for Upstream
Wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Elara6331/itd#69
No description provided.
Delete Branch "vchigrin/itd:fix-crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?