From 77eef63fac3f34b6fc627e40c81022c163f60c09 Mon Sep 17 00:00:00 2001
From: Hellow2 <lars.noack@outlook.de>
Date: Mon, 3 Apr 2023 12:14:58 +0200
Subject: [PATCH] fixed issue with crash on connection exception

---
 src/music_kraken/objects/target.py | 18 ++++++++++++++----
 src/music_kraken/pages/abstract.py | 27 ++++++++++++++++++---------
 src/music_kraken/pages/musify.py   |  6 ++----
 3 files changed, 34 insertions(+), 17 deletions(-)

diff --git a/src/music_kraken/objects/target.py b/src/music_kraken/objects/target.py
index b83b577..6d3162d 100644
--- a/src/music_kraken/objects/target.py
+++ b/src/music_kraken/objects/target.py
@@ -63,17 +63,25 @@ class Target(DatabaseObject):
             with open(copy_to.file_path, "wb") as write_to:
                 write_to.write(read_from.read())
 
-    def stream_into(self, r: requests.Response):
+    def stream_into(self, r: requests.Response) -> bool:
+        if r is None:
+            return False
+        
         self.create_path()
         
         chunk_size = 1024
         total_size = int(r.headers.get('content-length'))
         initial_pos = 0
         
-        with open(self.file_path,'wb') as f:      
-            for chunk in r.iter_content(chunk_size=chunk_size):
-                size = f.write(chunk) 
         
+        with open(self.file_path,'wb') as f:
+            try:
+                for chunk in r.iter_content(chunk_size=chunk_size):
+                    size = f.write(chunk) 
+            except requests.exceptions.Timeout:
+                shared.DOWNLOAD_LOGGER.error("Stream timed out.")
+                return False
+            
         """
         # doesn't work yet due to
         # https://github.com/tqdm/tqdm/issues/261
@@ -85,3 +93,5 @@ class Target(DatabaseObject):
                 size = f.write(chunk) 
                 pbar.update(size)
         """
+        
+        return True
diff --git a/src/music_kraken/pages/abstract.py b/src/music_kraken/pages/abstract.py
index 51b0fcb..cba14bf 100644
--- a/src/music_kraken/pages/abstract.py
+++ b/src/music_kraken/pages/abstract.py
@@ -60,6 +60,7 @@ class Page:
     API_SESSION.proxies = shared.proxies
     TIMEOUT = 5
     TRIES = 5
+    LOGGER = LOGGER
     
     SOURCE_TYPE: SourcePages
 
@@ -78,11 +79,11 @@ class Page:
             return r
 
         if not retry:
-            LOGGER.warning(f"{cls.__name__} responded wit {r.status_code} at GET:{url}. ({trie}-{cls.TRIES})")
-            LOGGER.debug(r.content)
+            cls.LOGGER.warning(f"{cls.__name__} responded wit {r.status_code} at GET:{url}. ({trie}-{cls.TRIES})")
+            cls.LOGGER.debug(r.content)
 
         if trie >= cls.TRIES:
-            LOGGER.warning("to many tries. Aborting.")
+            cls.LOGGER.warning("to many tries. Aborting.")
             return None
 
         return cls.get_request(url=url, stream=stream, accepted_response_codes=accepted_response_codes, trie=trie + 1)
@@ -102,11 +103,11 @@ class Page:
             return r
 
         if not retry:
-            LOGGER.warning(f"{cls.__name__} responded wit {r.status_code} at POST:{url}. ({trie}-{cls.TRIES})")
-            LOGGER.debug(r.content)
+            cls.LOGGER.warning(f"{cls.__name__} responded wit {r.status_code} at POST:{url}. ({trie}-{cls.TRIES})")
+            cls.LOGGER.debug(r.content)
 
         if trie >= cls.TRIES:
-            LOGGER.warning("to many tries. Aborting.")
+            cls.LOGGER.warning("to many tries. Aborting.")
             return None
 
         return cls.post_request(url=url, json=json, accepted_response_codes=accepted_response_codes, trie=trie + 1)
@@ -414,18 +415,26 @@ class Page:
                     continue
                 
                 existing_target.copy_content(target)
+            return True
         
         sources = song.source_collection.get_sources_from_page(cls.SOURCE_TYPE)
         if len(sources) == 0:
-            return
+            return False
         
         temp_target: Target = Target(
             path=shared.TEMP_DIR,
             file=str(random.randint(0, 999999))
         )
         
-        cls._download_song_to_targets(source=sources[0], target=temp_target)
-        cls._post_process_targets(song, temp_target)
+        success = True
+        
+        if not cls._download_song_to_targets(source=sources[0], target=temp_target):
+            success = False
+        
+        if not cls._post_process_targets(song, temp_target):
+            success = False
+        
+        return success
     
     @classmethod
     def _post_process_targets(cls, song: Song, temp_target: Target):
diff --git a/src/music_kraken/pages/musify.py b/src/music_kraken/pages/musify.py
index 579bbba..84515e8 100644
--- a/src/music_kraken/pages/musify.py
+++ b/src/music_kraken/pages/musify.py
@@ -9,10 +9,6 @@ from dataclasses import dataclass
 from pathlib import Path
 import random
 
-from ..utils.shared import (
-    ENCYCLOPAEDIA_METALLUM_LOGGER as LOGGER
-)
-
 from .abstract import Page
 from ..objects import (
     DatabaseObject,
@@ -88,6 +84,8 @@ class Musify(Page):
     HOST = "https://musify.club"
 
     SOURCE_TYPE = SourcePages.MUSIFY
+    
+    LOGGER = LOGGER
 
     @classmethod
     def parse_url(cls, url: str) -> MusifyUrl: