Crash in player.go after song changes #9

New Issue

brennana · 2022-03-03T22:37:56Z

brennana commented

2022-03-03 22:37:56 +00:00

Built itd-git from AUR (2f14e70721) on Pinephone Pro w/ Manjaro/KDE.

I've noticed that when a song changes (even manually) via MPRIS on my phone, itd will crash with the following message:

Mar 03 15:35:24 pinephonepro itd[58434]: panic: interface conversion: interface {} is string, not []string
Mar 03 15:35:24 pinephonepro itd[58434]: goroutine 119 [running]:
Mar 03 15:35:24 pinephonepro itd[58434]: go.arsenm.dev/infinitime/pkg/player.OnChange.func1()
Mar 03 15:35:24 pinephonepro itd[58434]:         /home/andy/go/pkg/mod/go.arsenm.dev/infinitime@v0.0.0-20220221104620-e82981e3fc4b/pkg/player/player.go:166 +0x5c0
Mar 03 15:35:24 pinephonepro itd[58434]: sync.(*Once).doSlow(0x886340, 0x4000590430)
Mar 03 15:35:24 pinephonepro itd[58434]:         /usr/lib/go/src/sync/once.go:68 +0x108
Mar 03 15:35:24 pinephonepro itd[58434]: sync.(*Once).Do(0x886340, 0x4000590430)
Mar 03 15:35:24 pinephonepro itd[58434]:         /usr/lib/go/src/sync/once.go:59 +0x38
Mar 03 15:35:24 pinephonepro itd[58434]: created by go.arsenm.dev/infinitime/pkg/player.OnChange
Mar 03 15:35:24 pinephonepro itd[58434]:         /home/andy/go/pkg/mod/go.arsenm.dev/infinitime@v0.0.0-20220221104620-e82981e3fc4b/pkg/player/player.go:135 +0x8c

Even with a freshly restarted daemon, each song change will induce this crash again.

Built itd-git from AUR (2f14e70721) on Pinephone Pro w/ Manjaro/KDE. I've noticed that when a song changes (even manually) via MPRIS on my phone, itd will crash with the following message: ``` Mar 03 15:35:24 pinephonepro itd[58434]: panic: interface conversion: interface {} is string, not []string Mar 03 15:35:24 pinephonepro itd[58434]: goroutine 119 [running]: Mar 03 15:35:24 pinephonepro itd[58434]: go.arsenm.dev/infinitime/pkg/player.OnChange.func1() Mar 03 15:35:24 pinephonepro itd[58434]: /home/andy/go/pkg/mod/go.arsenm.dev/infinitime@v0.0.0-20220221104620-e82981e3fc4b/pkg/player/player.go:166 +0x5c0 Mar 03 15:35:24 pinephonepro itd[58434]: sync.(*Once).doSlow(0x886340, 0x4000590430) Mar 03 15:35:24 pinephonepro itd[58434]: /usr/lib/go/src/sync/once.go:68 +0x108 Mar 03 15:35:24 pinephonepro itd[58434]: sync.(*Once).Do(0x886340, 0x4000590430) Mar 03 15:35:24 pinephonepro itd[58434]: /usr/lib/go/src/sync/once.go:59 +0x38 Mar 03 15:35:24 pinephonepro itd[58434]: created by go.arsenm.dev/infinitime/pkg/player.OnChange Mar 03 15:35:24 pinephonepro itd[58434]: /home/andy/go/pkg/mod/go.arsenm.dev/infinitime@v0.0.0-20220221104620-e82981e3fc4b/pkg/player/player.go:135 +0x8c ``` Even with a freshly restarted daemon, each song change will induce this crash again.

Elara6331 commented

2022-03-04 00:08:42 +00:00

Interesting. It appears your MPRIS DBus interface is different from mine. It may have been recently changed. When I was creating this, the value for artist was a string slice ([]string), but now it appears to be a single string. I will test this further and get back to you.

Interesting. It appears your MPRIS DBus interface is different from mine. It may have been recently changed. When I was creating this, the value for artist was a string slice (`[]string`), but now it appears to be a single string. I will test this further and get back to you.

Elara6331 added the

Bug

In Progress

labels 2022-03-04 00:08:57 +00:00

Elara6331 referenced this issue from a commit

2022-03-04 20:04:43 +00:00

Handle case where artists value is a single string rather than a slice. Fixes Arsen6331/itd#9.

Elara6331 closed this issue

2022-03-04 20:04:43 +00:00

Elara6331 referenced this issue from a commit

2022-03-04 20:06:04 +00:00

Update infinitime library for #9 fix