Elara Elara6331
Elara6331 pushed to master at Elara6331/itd 2023-03-25 22:23:52 +00:00
9ecd45dadd Added FUSE support (#55)
Elara6331 commented on pull request Elara6331/itd#55 2023-03-25 22:23:27 +00:00
Added FUSE support

I just tested it, and it looks good to me, merging now. Thanks!

Elara6331 commented on pull request Elara6331/itd#55 2023-03-12 20:10:54 +00:00
Added FUSE support

That looks good, thanks

Elara6331 commented on pull request Elara6331/itd#55 2023-03-12 20:10:31 +00:00
Added FUSE support

Yeah, instantaneous motion data doesn't make much sense, but the continuous motion data file also doesn't work all the time. InfiniTime will stop sending motion data if you have Raise To Wake and…

Elara6331 commented on pull request Elara6331/itd#55 2023-03-11 18:30:43 +00:00
Added FUSE support

Yeah, this one is going to be a bit more complicated. The FUSE library does have [an unmount function](0f728ba15b/fuse/mount_lin

Elara6331 commented on pull request Elara6331/itd#55 2023-03-11 18:04:22 +00:00
Added FUSE support

Could you perhaps elaborate on the problem you see?

Try this with something that returns data less commonly, such as battery. Every time cat tries to read from the file, it executes a…

Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support

In my opinion, "device" is unclear. I think it should be called "info" instead, that seems clearer.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support

This is not correct. If no content has been written, you should still create the file because the user might want to create a custom file using a command like touch.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support

Use os.MkdirAll here instead so that it creates parent directories, and handle the error (just return it).

Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support

err is returned twice here

Elara6331 suggested changes for Elara6331/itd#55 2023-03-08 23:48:36 +00:00
Added FUSE support
Elara6331 commented on pull request Elara6331/itd#55 2023-03-08 23:14:07 +00:00
Added FUSE support

Sorry it's taken me a while to respond. I wanted to test this PR but my PineTime wasn't booting. Now that I've gotten it to boot, I'll test this and get back to you.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 23:34:33 +00:00
Added FUSE support

The err can be several different kinds of errors, and FSError is just one of them. It's actually a type I made. You can see it here: https://gitea.arsenm.dev/Arsen6331/infinitime/src/commit/512…

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support
Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support
Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

These should be debug logs rather than info logs. Also, the message should be a bit more specific, something like "FUSE getattr". Same for all the similar logs.

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

Minor typo, it's "success"

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

You should definitely handle this error

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

This error needs to be handled, you can just return it in this case and update the code that calls this function to do the actual handling

Elara6331 commented on pull request Elara6331/itd#55 2023-03-01 17:29:01 +00:00
Added FUSE support

These variables should go above BuildRootNode because it's using them and it would be more readable that way. Also, Go doesn't require semicolons, you can remove those.