Elara6331/itd
4
6
Fork 12
Code Issues 8 Pull Requests 1 Projects Releases 11 Wiki Activity

Warn when Koanf read fails #47

Merged
Elara6331 merged 3 commits from Hunman/itd:error-handling into master 2023-01-02 09:05:24 +00:00
Conversation 1 Commits 3 Files Changed 1 +2 -3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7e4c916f0e - Show all commits

5
config.go
View File

@ -1,7 +1,6 @@
package main package main
import ( import (
"fmt"
"os" "os"
"path/filepath" "path/filepath"
"strings" "strings"
@ -68,7 +67,7 @@ func loadAndwatchCfgFile(filename string) {
provider := file.Provider(filename) provider := file.Provider(filename)
if cfgError := k.Load(provider, toml.Parser()); cfgError != nil { if cfgError := k.Load(provider, toml.Parser()); cfgError != nil {
log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error())) log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file")
} }
Hunman marked this conversation as resolved
Elara6331 commented 2023-01-02 02:59:28 +00:00
Review
Copy Link
- log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error()))
+ log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file")
```diff - log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error())) + log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file") ```
// Watch for changes and reload when detected // Watch for changes and reload when detected
@ -78,7 +77,7 @@ func loadAndwatchCfgFile(filename string) {
} }
if cfgError := k.Load(provider, toml.Parser()); cfgError != nil { if cfgError := k.Load(provider, toml.Parser()); cfgError != nil {
log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error())) log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file")
} }
Hunman marked this conversation as resolved
Elara6331 commented 2023-01-02 03:00:06 +00:00
Review
Copy Link

Same as above

- log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error()))
+ log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file")
Same as above ```diff - log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error())) + log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file") ```
}) })
} }