Elara6331/itd
4
6
Fork 12
Code Issues 8 Pull Requests 1 Projects Releases 11 Wiki Activity

sometimes authentication fails and passcode gets treated as shell input #42

New Issue
Closed
opened 2022-11-23 22:46:02 +00:00 by mashuptwice · 3 comments
mashuptwice commented 2022-11-23 22:46:02 +00:00
Contributor
Copy Link

Sometimes the authentication fails after pressing enter and part of the passcode gets treated as input to the shell.

Two examples:

╰─$ itd
Passkey: 056950
11:20PM FTL Error connecting to InfiniTime error="Authentication Failed"
╭─mashuptwice@yoga ~ ‹yoga› 
╰─$ 50                                                                                                                                                                                                         1 ↵
zsh: command not found: 50

╰─$ itd
Passkey: 056094 
11:41PM FTL Error connecting to InfiniTime error="Authentication Failed"
╭─mashuptwice@yoga ~ ‹yoga› 
╰─$ 4                                                                                                                                                                                                          1 ↵
cd: no such entry in dir stack

This happens seemingly at random, maybe once every 10 pairing attempts.

I use zsh and haven't tested it with bash yet.

Sometimes the authentication fails **after** pressing enter and part of the passcode gets treated as input to the shell. Two examples: ``` ╰─$ itd Passkey: 056950 11:20PM FTL Error connecting to InfiniTime error="Authentication Failed" ╭─mashuptwice@yoga ~ ‹yoga› ╰─$ 50 1 ↵ zsh: command not found: 50 ╰─$ itd Passkey: 056094 11:41PM FTL Error connecting to InfiniTime error="Authentication Failed" ╭─mashuptwice@yoga ~ ‹yoga› ╰─$ 4 1 ↵ cd: no such entry in dir stack ``` This happens seemingly at random, maybe once every 10 pairing attempts. I use zsh and haven't tested it with bash yet.
Elara6331 commented 2022-11-23 22:47:19 +00:00
Owner
Copy Link

ITD's errors all follow Go's convention and start with lowercase letters. If you see capitalized error messages, they came from BlueZ, not ITD.

ITD's errors all follow Go's convention and start with lowercase letters. If you see capitalized error messages, they came from BlueZ, not ITD.
Elara6331 commented 2022-11-23 22:49:58 +00:00
Owner
Copy Link

What happens is BlueZ returns an error before ITD even reads the whole passkey from stdin, so it gets left on there and zsh reads that after ITD exits.

What happens is BlueZ returns an error before ITD even reads the whole passkey from stdin, so it gets left on there and zsh reads that after ITD exits.
Elara6331 commented 2023-01-02 23:57:37 +00:00
Owner
Copy Link

There isn't much I can do about this, so I will close this issue

There isn't much I can do about this, so I will close this issue
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Bug
Something is not working
Cantfix
This issue cannot be fixed in ITD
Duplicate
This issue or pull request already exists
Enhancement
New feature
External
This issue is not in ITD
Help Wanted
Need some help
In Progress
This issue is currently being worked on
Invalid
Something is wrong
Question
More information is needed
Waiting
Waiting for something external to be completed to allow completion of issue
Waiting For Info
Waiting for additional information about issue
Waiting for Upstream
Waiting for an upstream project to fix an issue
Wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Elara6331
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Elara6331/itd#42
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?