Elara6331/infinitime
Archived
2
0
Fork 4
Code Issues Pull Requests Projects Releases Wiki Activity

Added Navigation service #5

Merged
Elara6331 merged 9 commits from yannickulrich/infinitime:navigation-service into master 2022-11-03 19:09:07 +00:00
Conversation 3 Commits 9 Files Changed 3 +8
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 62987fa31b - Show all commits

8
infinitime.go
View File

@ -62,6 +62,13 @@ var charNames = map[string]string{
NavProgressChar: "Navigation Progress",
}
type NavigationEvent struct {
yannickulrich marked this conversation as resolved Outdated
Elara6331 commented 2022-10-21 22:34:57 +00:00
Outdated
Review
Copy Link

I think it would be better if these were individual constants rather than a slice. That way, they could have their own type and the compiler can guarantee that they're valid instead of needing a separate function. Since that will add quite a bit of code, I think the navigation service can be moved into a separate file.

I think it would be better if these were individual constants rather than a slice. That way, they could have their own type and the compiler can guarantee that they're valid instead of needing a separate function. Since that will add quite a bit of code, I think the navigation service can be moved into a separate file.
Elara6331 commented 2022-10-21 22:41:38 +00:00
Outdated
Review
Copy Link

Maybe something like

type NavFlag string

const (
    NavFlagArrive     NavFlag = "arrive"
    NavFlagArriveLeft NavFlag = "arrive-left"
    // ...
)

Then, the NavigationEvent can take a NavFlag instead of string.

Maybe something like ```go type NavFlag string const ( NavFlagArrive NavFlag = "arrive" NavFlagArriveLeft NavFlag = "arrive-left" // ... ) ``` Then, the `NavigationEvent` can take a `NavFlag` instead of `string`.
yannickulrich commented 2022-10-22 12:57:06 +00:00
Outdated
Review
Copy Link

Taken care of in d46f545

Taken care of in d46f545
flag string
narrative string
dist string
progress uint8
}
type Device struct {
device *device.Device1
navflagsChar *gatt.GattCharacteristic1
@ -83,6 +90,7 @@ type Device struct {
notifEventDone bool
Music MusicCtrl
DFU DFU
navigationEv NavigationEvent
}
var (