Elara6331/infinitime
Archived
2
0
Fork 4
Code Issues Pull Requests Projects Releases Wiki Activity

replace pactl based volume control with mpris based volume control #6

Merged
Elara6331 merged 2 commits from FloralExMachina/infinitime:master into master 2022-11-19 22:46:13 +00:00
Conversation 3 Commits 2 Files Changed 3 +45 -21
FloralExMachina commented 2022-11-19 22:21:22 +00:00
Contributor
Copy Link

Currently, the infinitime library relys on external commands for volume control with music, this has the pro of allowing the user to control the general volume of the device currently bound to the watch, however without more complex commands this falls short if the user has multiple pulseaudio sinks or does not use pulseaudio. This is also an inconsistancy in design, the InfiniTime firmware expose volume control within the Music control app, and itd exposes the volume control interval in its config as a property of the music player, in my opinion a user would expect these control to only affect the volume of music, not the system volume. This PR attempts to correct these issues by changing volume control to use the MPRIS player volume property.

An alternative solution, would be to move music controls into itd, and allow the user to provide commands within the itd config on music event.

Currently, the infinitime library relys on external commands for volume control with music, this has the pro of allowing the user to control the general volume of the device currently bound to the watch, however without more complex commands this falls short if the user has multiple pulseaudio sinks or does not use pulseaudio. This is also an inconsistancy in design, the InfiniTime firmware expose volume control within the Music control app, and itd exposes the volume control interval in its config as a property of the music player, in my opinion a user would expect these control to only affect the volume of music, not the system volume. This PR attempts to correct these issues by changing volume control to use the MPRIS player volume property. An alternative solution, would be to move music controls into itd, and allow the user to provide commands within the itd config on music event.
FloralExMachina added 1 commit 2022-11-19 22:21:22 +00:00 
methods
Elara6331 commented 2022-11-19 22:24:23 +00:00
Owner
Copy Link

This is a good idea, thanks. Can you also update the README and remove the pulseaudio-utils and libpulse dependencies? Thank you.

This is a good idea, thanks. Can you also update the README and remove the `pulseaudio-utils` and `libpulse` dependencies? Thank you.
FloralExMachina added 1 commit 2022-11-19 22:44:52 +00:00
FloralExMachina commented 2022-11-19 22:45:15 +00:00
Author
Contributor
Copy Link

done :)

done :)
Elara6331 commented 2022-11-19 22:46:02 +00:00
Owner
Copy Link

Thanks, merging now

Thanks, merging now
Elara6331 merged commit 0c369dc5df into master 2022-11-19 22:46:13 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Elara6331/infinitime#6
No description provided.
Delete Branch "FloralExMachina/infinitime:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?